Fix Events and add TODOs for the next major release #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sephster
requested changes
Dec 20, 2024
Member
Sephster
left a comment
Sephster
left a comment
There was a problem hiding this comment.
Thanks for this @hafezdivandari and thanks for your ongoing work with the library. Would it be possible to add a test for the event emissions and a changelog entry? If you don't have time I can take a look at this. Thank you
Contributor
Author
|
Sure @Sephster I'll complete this asap. |
Contributor
Author
|
@Sephster a changelog entry and tests for events have been added. |
Contributor
Author
|
@Sephster please don't forget about this one, before release, thanks. |
formatting formatting formatting fix backward compatibility bump lcobucci/jwt
hafezdivandari
force-pushed
the
master-fix-events
branch
from
55d91a3 to
58908c6
Compare
Member
|
Will be looking at this tonight/this weekend to get a new release tagged |
Sephster
approved these changes
Feb 14, 2025
Member
Sephster
left a comment
Sephster
left a comment
There was a problem hiding this comment.
Looks good. Thanks @hafezdivandari
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1465
\League\OAuth2\Server\Repositories\DeviceCodeRepositoryInterface::getDeviceCodeEntityByDeviceCode()method on the next major release:string $deviceCodeEntity->string $deviceCode