Add missing scanBlankSpace parsing &&s
#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1985 1986 +1
=========================================
+ Hits 1985 1986 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add `lex.scanBlankSpace()` to the loop in `Parser.parseLogicalAndExpr` so that multiple consecutive `&&` comparison expressions delimited by blank spaces will be properly parsed. Add tests to ensure that the multiple consecutive `||` comparison expressions are also properly parsed. Thanks @jarangutan for the report and @jg-rp for the analysis. Resolves #24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
lex.scanBlankSpace()to the loop inParser.parseLogicalAndExprso that multiple consecutive&&comparison expressions delimited by blank spaces will be properly parsed. Add tests to ensure that the multiple consecutive||comparison expressions are also properly parsed. Thanks @jarangutan for the report and @jg-rp for the analysis. Resolves #24.