Skip to content

Add Mattermost Connector and its documentation #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bibich
Copy link
Contributor

@bibich bibich commented Feb 5, 2025

Hi there!
Here is a proposition for a Mattermost connector.
It's quite basic for now and it's my first contribution to tock, so do not hesitate to tell me what's wrong.

@vsct-jburet vsct-jburet self-requested a review February 14, 2025 08:13
@Benvii Benvii self-requested a review February 14, 2025 10:10
Copy link
Member

@Benvii Benvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bibich for this contribution, see my review comments.

About the documentation a huge refactoring was done and some files have moved to different location but it should be easy to report your changes.
I suggestion you start with a rebasing then report your changes to the moved files.

Do you think a demo of this connector could be done during one the Tock Virtual Coffee (I see you are already in the invite), we could also help you about the remain todos (for instance reply on the original channel could be done using metadata to keep the channelID..).

@bibich bibich force-pushed the feature/mattermost-connector branch from 85a8d33 to 1e856dc Compare March 11, 2025 08:42
@bibich
Copy link
Contributor Author

bibich commented Mar 11, 2025

@Benvii Thanks for your detailed review.

I've resolved all issues you reported. Sorry for the delay.
Let me know if it's ok for you now.

Do you think a demo of this connector could be done during one the Tock Virtual Coffee (I see you are already in the invite), we could also help you about the remain todos (for instance reply on the original channel could be done using metadata to keep the channelID..).

Sure. But I'm not sure to be available this week, but the next one it will be fine.

@vsct-jburet vsct-jburet added this to the 25.3.0 milestone Mar 19, 2025
Copy link
Member

@Benvii Benvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and the fixes @bibich 🙂, sorry for the late approval

@vsct-jburet vsct-jburet merged commit 2c1249d into theopenconversationkit:master Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants