-
Notifications
You must be signed in to change notification settings - Fork 148
Add Mattermost Connector and its documentation #1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mattermost Connector and its documentation #1840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bibich for this contribution, see my review comments.
About the documentation a huge refactoring was done and some files have moved to different location but it should be easy to report your changes.
I suggestion you start with a rebasing then report your changes to the moved files.
Do you think a demo of this connector could be done during one the Tock Virtual Coffee (I see you are already in the invite), we could also help you about the remain todos (for instance reply on the original channel could be done using metadata to keep the channelID..).
bot/connector-mattermost/src/main/kotlin/MattermostConnector.kt
Outdated
Show resolved
Hide resolved
bot/connector-mattermost/src/main/kotlin/MattermostConnector.kt
Outdated
Show resolved
Hide resolved
85a8d33
to
1e856dc
Compare
@Benvii Thanks for your detailed review. I've resolved all issues you reported. Sorry for the delay.
Sure. But I'm not sure to be available this week, but the next one it will be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates and the fixes @bibich 🙂, sorry for the late approval
Hi there!
Here is a proposition for a Mattermost connector.
It's quite basic for now and it's my first contribution to tock, so do not hesitate to tell me what's wrong.