-
Notifications
You must be signed in to change notification settings - Fork 36
Manage options #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kenyon
wants to merge
8
commits into
theforeman:master
Choose a base branch
from
kenyon:manage-options
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Manage options #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adjusts the name of the dropin file for RedHat, since root-directory.conf didn't seem to make sense since this configures more than just the tftpd root directory.
bastelfreak
reviewed
Nov 8, 2025
bastelfreak
reviewed
Nov 8, 2025
bastelfreak
reviewed
Nov 8, 2025
Co-authored-by: Tim Meusel <[email protected]>
Co-authored-by: Tim Meusel <[email protected]>
ec48337 to
15dd786
Compare
b82f939 to
d6d3313
Compare
Author
|
Not sure what we need to do to bring in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes #115 and makes small changes to enable management of tftpd options. See also #153 and #141, but my PR is intended to be small enough to review easily so that we can merge it, then add the other features of those other PRs.