-
Notifications
You must be signed in to change notification settings - Fork 45
WWWData.h build script update #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added core temp * added mDNS service and recovery mode * Final touch recovery mode incl. docs * Updated to Svelte 4 * Revert back to Svelte 3, CHANGELOG and push notifications * Fixed drawer issue introduced with DaisyUI 3.1.6 * Added telemetry via SSE for RSSI * FT_PROJECT feature flag removed * fimware version in factory_settings.ini and SystemStatus API * Deep Sleep Service API * Added battery indicator & service * Restructured OTA * Improvements System Status * WIP github update * Github Release OTA * Update documentation for github updates * Refactor WebSocket Server Code * Error messages for SSE and WS * Mark 53.33 degC als invalid * Generate SSL Root CA Store * build script for ssl certificate store * different ssl build config * Version updates * default env S3 * Update CHANGELOG.md * WebSocketClient Trials * WebSocketTrials * Learnings from other projects * Fixes for platformio issue * fixes for Arduino 6.4.0 * updated docs * hard fork ESPAsyncWebserver + System Metrics * Update docs
…when ROGMEM_WWW is used.
Owner
|
@EvEggelen Thank you for submitting this pull request. I have a couple of questions regarding your code:
#include <functional>
#if defined(ARDUINO)
#include <Arduino.h>
#else
#define PROGMEM
#endif
|
Contributor
Author
|
Owner
|
OK, understand. I'll test the code the coming days and merge it with the mainline. |
Owner
|
@EvEggelen There was a small bug in your script. You compared the file creation date instead of the last file modification date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-updated build script that only re-builds WWWData.h when source files are updated ( only working when compile def PROGMEM_WWW is used )
-added support for nodemcu-32s board
-fixed build issues on Linux ( when using case sensitive filesystem); renamed spinner.svelte-> Spinner.svelte