Skip to content

Conversation

@EvEggelen
Copy link
Contributor

-updated build script that only re-builds WWWData.h when source files are updated ( only working when compile def PROGMEM_WWW is used )
-added support for nodemcu-32s board
-fixed build issues on Linux ( when using case sensitive filesystem); renamed spinner.svelte-> Spinner.svelte

theelims and others added 5 commits October 8, 2023 12:38
* Added core temp

* added mDNS service and recovery mode

* Final touch recovery mode incl. docs

* Updated to Svelte 4

* Revert back to Svelte 3, CHANGELOG and push notifications

* Fixed drawer issue introduced with DaisyUI 3.1.6

* Added telemetry via SSE for RSSI

* FT_PROJECT feature flag removed

* fimware version in factory_settings.ini and SystemStatus API

* Deep Sleep Service API

* Added battery indicator & service

* Restructured OTA

* Improvements System Status

* WIP github update

* Github Release OTA

* Update documentation for github updates

* Refactor WebSocket Server Code

* Error messages for SSE and WS

* Mark 53.33 degC als invalid

* Generate SSL Root CA Store

* build script for ssl certificate store

* different ssl build config

* Version updates

* default env S3

* Update CHANGELOG.md

* WebSocketClient Trials

* WebSocketTrials

* Learnings from other projects

* Fixes for platformio issue

* fixes for Arduino 6.4.0

* updated docs

* hard fork ESPAsyncWebserver + System Metrics

* Update docs
@theelims
Copy link
Owner

@EvEggelen Thank you for submitting this pull request.

I have a couple of questions regarding your code:

  1. Why do you include this in the WWWData.h file?
    #include <functional>
    #if defined(ARDUINO)
      #include <Arduino.h>
    #else
      #define PROGMEM
    #endif
  1. Also what's the purpose of #define WWW_NR_PAGES and the page_entry_t struct?
  2. You have included "[ code available under dual license ]" behind your copyright note. I see this conflicting with the licencing and would like to remove this statement (keeping just your name)

@EvEggelen
Copy link
Contributor Author

  1. This adds support for the ESP-IDF framework for the WWWData.h file.
  2. My background is automotive software that needs to comply with the MISRA standard. Then one of the requirements is to function without dynamic memory allocation ( to give guaranties ). So you need to assign all memory at startup. This define indicates how many files are generated so you can know how much memory to allocate. This is also needed for the IDF HTTPS server as it also pre-allocates a maximum number of end-points at start of the server. Even PsychicHttp cannot hide this ( current it is set a "large" number at a cost ). The struct enables serving files from a structure from flash without memory on the heap. But this is only use-full with the new HTTP server ( making progress) . The compiler removes it when not used.
  3. I moved some code (in this case snippets) from my company to the opensource project. I have not troubles sharing code to the public. But I do not want the requirements from LGPL coming in my own code base because I shared some code. This remark is there to indicate that my contributions are also available under a different license ( dual license ). For this build script I expect this is not critical, but for large contributions it can matter.

@theelims
Copy link
Owner

OK, understand. I'll test the code the coming days and merge it with the mainline.

@theelims theelims changed the base branch from main to features December 29, 2023 07:26
@theelims theelims merged commit abb7e09 into theelims:features Jan 7, 2024
@theelims
Copy link
Owner

theelims commented Jan 7, 2024

@EvEggelen There was a small bug in your script. You compared the file creation date instead of the last file modification date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants