Clipping is not related to the window with the latest imgui

[Namek]

I have updated imgui from 1.88dock to 1.89.3dock. The screen is cut, depending on the position. It seems the editor has the size of the window but its clipping is not related to the window but rather to the world space (?).

The recording should explain what's going on, notice the huge black parts around the editor:

app_Gsf0CuRIrC.mp4

What's interesting though, I've found this code in the imgui_canvas.cpp:

    // #debug: Canvas content.
    //m_DrawList->AddRectFilled(m_StartPos, m_StartPos + m_CurrentSize, IM_COL32(0, 0, 0, 64));
    //m_DrawList->AddRect(m_WidgetRect.Min, m_WidgetRect.Max, IM_COL32(255, 0, 255, 64));

I have uncommented the last line and it seems to fix everything (it is, remove the black parts and not crop the content):

However, it doesn't seem to be a proper fix since it is commented as debug code.

[Namek]

After further testing it turned it the workaround with uncommenting the line doesn't work when Suspend/Resume is used.

nodes.Suspend();
c.igBeginTooltip();
c.igTextUnformatted(text, null);
c.igEndTooltip();
nodes.Resume();

See how the appearing tooltip brings back the issue:

app_ASilm6ugow.mp4

[rtryan98]

Got a similar issue. Uncommenting the second line will bring back the canvas into the docked window space. However, my popup does appear in some other coordinate system and doesn't bring back the window background.

[azonenberg]

I updated from 1.89.1, I think? to latest in order to debug some suspend/resume issues and got hit by this instead.

Interestingly, the workaround seems to work great when the node editor window is docked. It only fails calling Suspend/Resume when undocked.

[Namek]

I reviewed the diff between tags v1.88 and v1.89 and I believe the change might be found in one of those commits:

• 4eb9066997a95c556336b7ab5f246f0cdbf151c2
• 72096bf6986d0bcc4543537dcfc581451d36ec29

[azonenberg]

Given the dependency between docking and the workaround, is it possible this is an upstream bug? @ocornut have you seen this before?

[ocornut]

I reviewed the diff between tags v1.88 and v1.89 and I believe the change might be found in one of those commits:

Those commits are related to the ImGuiListClipper which seems to have nothing to do with this.

This is not my codebase so hard to say, first you would need to do a proper git bisect to find the commit that changed the behavior and then we can figure out if this is a dear imgui behavior change/bug or a bug in the node editor code.

Also try to open Metrics->DrawList and inspect the data here to see if there's a correlation.

[ocornut]

I tried to rebase the stack-layout imgui/, checked out imgui-node-editor/develop, updated the copy with latest rebased imgui + stack-layout (with few fixes pushed to #208) and couldn't see an issue.

Please actually provide details as to how to reproduce the issue in imgui-node-editor .
I don't even know what example of node-editor looks like the one you posted screenshot of above.

[Namek]

@azonenberg @rtryan98 I welcome you to make a SSCCEE to reproduce that issue, as stated above. As this is not critical for me to update imgui right now, I am not pursuing it in the following days.

[thedmd]

@Namek Does updating ImGui solved the issue for you?

[azonenberg]

Just checked with latest imgui from git and the issue is still present.