fix: for symfony 6 and php8.1 #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
Author
|
Relates to thecodingmachine/graphqlite-bundle#174 |
aszenz
commented
Jun 23, 2023
| * | ||
| * Value "graphql" is reserved for errors produced by query parsing or validation, do not use it. | ||
| */ | ||
| public function getCategory(): string |
Contributor
Author
There was a problem hiding this comment.
ClientAware no longer has this method now, see webonyx/graphql-php#830 for why they removed the category
aszenz
commented
Jun 23, 2023
| public function getExtensions(): array | ||
| { | ||
| $extensions = []; | ||
| $extensions = ['category' => 'Validate']; |
Contributor
Author
There was a problem hiding this comment.
To keep tests running and for backwards compatibility i added category to extensions manually
Member
|
Thank you so much @aszenz !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required before fixing tests for graphlite-bundle
I suggest we fix this pkg first