Propose: add preferWords option #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
reviewed
Aug 7, 2021
README.md
Outdated
| * 定義された見出し語以外の同義語をエラーにします | ||
| * 例) ["ユーザー"] // => 「ユーザー」だけ許可し「ユーザ」などはエラーにする | ||
| */ | ||
| allowsOnly?: string[]; |
There was a problem hiding this comment.
another options?
preferWordsdictmyWords
他のallowはtrueなら無視する感じなので、allowじゃない方が良い気がします。
あんまりいいものが思いついてないですが
There was a problem hiding this comment.
preferWordsいいですね！リネームします。
Leko
force-pushed
the
feat-allows-only
branch
2 times, most recently
from
db3b9df to
0658f9f
Compare
azu
reviewed
Aug 8, 2021
src/textlint-rule-no-synonyms.ts
Outdated
| @@ -87,7 +95,19 @@ const report: TextlintRuleReporter<Options> = (context, options = {}) => { | |||
| allowAlphabet, | |||
| allowNumber | |||
| }); | |||
| if (items.length >= 2) { | |||
| const allowedTerm = preferWords.find(midashi => itemGroup.getItem(midashi)) | |||
There was a problem hiding this comment.
Suggested change
| const allowedTerm = preferWords.find(midashi => itemGroup.getItem(midashi)) | |
| const preferWord = preferWords.find(midashi => itemGroup.getItem(midashi)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an option so that users could use the same terminology throughout the documents.
We can make this a fixable rule as we know the acceptable term.
This is not a breaking change.