-
Couldn't load subscription status.
- Fork 1
fix: Expose cached PDF path to WebView to reduce loading delays #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
syed-tp
commented
Oct 8, 2025
- To improve the user experience when viewing AI PDFs, cached files are now exposed to the WebView.
- This ensures faster loading by using locally stored PDFs instead of fetching them from remote URLs, reducing wait times and improving responsiveness.
Summary of ChangesHello @syed-tp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR optimizes PDF loading in WebViews by exposing cached PDF paths via a new JavaScript interface. The Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Thank you for this contribution. The changes to expose the cached PDF path to the WebView for faster loading are a great user experience improvement. I've reviewed the code and have a few suggestions to improve maintainability and code quality. My comments focus on reducing coupling, eliminating magic strings, and simplifying the code. Please take a look at the detailed comments.
course/src/main/java/in/testpress/course/fragments/AIChatPdfFragment.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/in/testpress/course/fragments/AIChatPdfFragment.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/in/testpress/course/util/PDFPathInterface.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/in/testpress/course/util/PDFPathInterface.kt
Outdated
Show resolved
Hide resolved
b09d02d to
faff7ba
Compare