Skip to content

Conversation

@syed-tp
Copy link

@syed-tp syed-tp commented Oct 8, 2025

  • To improve the user experience when viewing AI PDFs, cached files are now exposed to the WebView.
  • This ensures faster loading by using locally stored PDFs instead of fetching them from remote URLs, reducing wait times and improving responsiveness.

@gemini-code-assist
Copy link

Summary of Changes

Hello @syed-tp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR optimizes PDF loading in WebViews by exposing cached PDF paths via a new JavaScript interface. The AIChatPdfFragment now passes local PDF paths from DocumentViewerFragment to the WebView, enabling faster loading from local storage.

Highlights

  • Intent: This pull request aims to improve the user experience when viewing AI PDFs by reducing loading delays. It achieves this by exposing locally cached PDF file paths to the WebView, allowing it to load PDFs from local storage instead of fetching them remotely.
  • Changes: The changes introduce a new PDFPathInterface class that acts as a JavaScript interface for WebViews, providing methods to check if a PDF is cached (isPDFCached), get its absolute path (getCachedPDFPath), and retrieve its file name (getPDFFileName). The DocumentViewerFragment now includes a getCachedPdfPath() method to return the local path of a downloaded PDF. The AIChatPdfFragment has been updated to utilize this new functionality by importing PDFPathInterface, retrieving the cached PDF path from its parent DocumentViewerFragment, and then adding an instance of PDFPathInterface to the WebViewFragment under the name 'PDFHandler'. This allows the WebView to interact with the native Android code to determine and use locally stored PDF files.
  • Reviewer Activity: No specific reviewer activity was provided in the context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Thank you for this contribution. The changes to expose the cached PDF path to the WebView for faster loading are a great user experience improvement. I've reviewed the code and have a few suggestions to improve maintainability and code quality. My comments focus on reducing coupling, eliminating magic strings, and simplifying the code. Please take a look at the detailed comments.

@syed-tp syed-tp force-pushed the fix/add_pdfpath_webview branch from b09d02d to faff7ba Compare October 9, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants