Skip to content

Conversation

@Gowreesh-A-M
Copy link
Contributor

  • Added a setting to change orientation to landscape only when fullscreen mode is entered in WebView.
  • Updated activities to respect this setting.
  • WebChromeClient applies the orientation change on fullscreen.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Gowreesh-A-M, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a new feature that allows for configurable screen orientation behavior when a WebView enters fullscreen mode. Specifically, it introduces a lockToLandscape setting which, when enabled, will automatically switch the device's orientation to landscape for an immersive fullscreen experience. This change provides greater control over the user interface during media playback or other fullscreen WebView content.

Highlights

  • New lockToLandscape Setting: Introduced a new boolean setting lockToLandscape in WebViewFragment to control whether the screen should automatically switch to landscape when entering fullscreen mode in a WebView.
  • Conditional Orientation Change: The CustomWebChromeClient now uses this lockToLandscape setting to decide whether to force SCREEN_ORIENTATION_SENSOR_LANDSCAPE or SCREEN_ORIENTATION_SENSOR when a WebView enters fullscreen.
  • Activity Integration: AbstractWebViewActivity, WebViewActivity, and WebViewWithSSO have been updated to pass and utilize this new LOCK_TO_LANDSCAPE setting, ensuring consistent behavior across different WebView implementations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new feature to switch to landscape orientation when fullscreen mode is activated in WebView. The changes involve adding a setting to control this behavior and updating activities and the WebChromeClient to respect the setting. The code changes look good, and I have added a review comment to address a potential issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants