-
Notifications
You must be signed in to change notification settings - Fork 112
Add a Vue Apollo example #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 69 69
Branches 13 13
=========================================
Hits 69 69 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm by no means an Apollo expert, but looks great! Thank you for this
I also used screen, is that alright or should i redo it using the destructing approach used everywhere else?
Totally fine. screen
is the suggested way to within Testing Lib ecosystem, so at some point docs and examples should be updated. Glad that this one is already in shape :)
I guess I should also add a note this is only for Apollo v2 and will not work with Apollo v3. |
Things I've changed now:
I think this PR is in a good state now, feel free to merge. 🙌 ✨ |
@cilice I think this comment went out the minute you pushed, you might have missed it xD |
Oh thats neat, it somehow never crossed my mind to solve it like this. It's great! I've changed it now and squashed it all into one commit. |
@afontcu I think it’s ready to merge 🙏 |
🎉 This PR is included in version 5.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #141
I had some freedom the pick some kind of a mocking client for apollo since
vue-apollo
doesn't provide one.I also used
screen
, is that alright or should i redo it using the destructing approach used everywhere else?