chore(deps): bump all minor versions #310
Conversation
|
Thanks Bala! I'll check and merge soon. Regarding the bot, we had it. But it's kind of annoying. It keeps us busy with updating, even when things aren't broken. I'd rather do bulk updates once in a while. |
|
A bot could be more a pain than a help. Sometime is better to update every month everything. Anyway we don't have tests for all the codebase so updating libraries could be a problem xD. |
package.json
Outdated
| "codemirror": "5.54.0", | ||
| "crx-bridge": "^2.1.0", | ||
| "crx-bridge": "^3.0.1", |
There was a problem hiding this comment.
I'm not sure if it's a good thing to add this major bump here, as crx-bridge has changed quite a bit to add support for Firefox.
Should this one be reverted?
There was a problem hiding this comment.
I had tested it worked. But I didn't any release notes. So should I revert it?
There was a problem hiding this comment.
Did you test the build & functioning of the chrome extension? That's where crx-bridge is being used.
If it works, we can merge it.
|
@balavishnuvj, can you fix the conflicts? 😇 I'll hit merge right after. |
|
will fix them today! |
…nd into chore/update-minor-dep-12-20
|
@smeijer have updated. Also have reverted |
smeijer
changed the title
|
Thanks, Bala! |
|
@all-contributors please add @balavishnuvj for code |
|
I've put up a pull request to add @balavishnuvj! 🎉 |
Updated minor reps by running
npm update. Probably we should have bot to this 😅. I was looking into someother issue when I noticed this. Feel free to discard if this is not necessary.Can you give a follow up PR where deps have major changes.