Skip to content

fix: overflow issue in embed modal #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2020
Merged

fix: overflow issue in embed modal #241

merged 1 commit into from
Jul 4, 2020

Conversation

smeijer
Copy link
Member

@smeijer smeijer commented Jul 4, 2020

What:
Forgot to push the last commit before merging #240

Why:
Mistakes happen?

How:
Trying to do too much at once

Checklist:

  • Tests
  • Ready to be merged

@smeijer smeijer added the bug Something isn't working label Jul 4, 2020
@smeijer smeijer self-assigned this Jul 4, 2020
@smeijer smeijer merged commit 7e47150 into develop Jul 4, 2020
@smeijer smeijer deleted the feature/fix-embed-overflow branch July 4, 2020 19:03
@delca85
Copy link
Member

delca85 commented Jul 5, 2020

Hey!
I found out this solves a layout issue I just discovered in https://develop.testing-playground.com/ , so I am not going to open an issue anymore about it, ok?

@delca85 delca85 mentioned this pull request Jul 5, 2020
Merged
2 tasks
@smeijer
Copy link
Member Author

smeijer commented Jul 5, 2020

But this one is already merged. So it's running on develop.testing-playground.com as well. If you find issues there, it means that this PR didn't fix them (properly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smeijer smeijer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smeijer @delca85