Skip to content

feat: save state as gist #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 4, 2020
Merged

feat: save state as gist #232

merged 10 commits into from
Jul 4, 2020

Conversation

smeijer
Copy link
Member

@smeijer smeijer commented Jul 1, 2020

What:
Use GitHub Gists as persistent storage

Why:

  1. Shorter shareable urls
  2. Stop history spamming

How:
I've added some labmda's that store and load markup, query and settings to and from gists. And adjusted the frontend to make use of that.

I've also added a new script npm run dev that spawns the application using netlify dev. This enables us to test front + backend on our local environments.

Checklist:

  • Tests
  • Ready to be merged

TODO:

  • fix /events route
  • add backward compatibility for loading from state
  • check embed mode
  • check extension

@smeijer smeijer self-assigned this Jul 1, 2020
@smeijer smeijer force-pushed the feature/save-as-gist branch from 8c874ee to 84bc092 Compare July 2, 2020 18:30
@smeijer smeijer force-pushed the feature/save-as-gist branch from 82f34ff to 94deb45 Compare July 4, 2020 08:37
@smeijer
Copy link
Member Author

smeijer commented Jul 4, 2020

Done 😎

@smeijer smeijer marked this pull request as ready for review July 4, 2020 09:48
@smeijer smeijer merged commit c793cfc into develop Jul 4, 2020
@smeijer smeijer deleted the feature/save-as-gist branch July 4, 2020 11:20
This was referenced Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant