fix(extension): toggle inspecting on button click #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smeijer do you why for my branches the CI fails to assign PR? For another PR I had the same issue |
smeijer
reviewed
Jul 1, 2020
|
right I didn't think about it. I have added a |
smeijer
changed the title
I have no idea. I did change something. So on your next PR, we'll know if it works. Unfortunately, I can't rerun it on this one with the new config. |
|
Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #228
What: I have fixed an issue where the user can't disable inspecting after click on the icon
Why: User can't use the browser without a refresh
How: By saving state in a ref and toggle inspecting checking this
Checklist: