feat: add "snapshot" function for wrapper elements #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome 💯 I love thanks for your contribution 🥳 |
|
This is neat!! |
smeijer
reviewed
Jun 19, 2020
smeijer
approved these changes
Jun 19, 2020
smeijer
changed the title
|
@all-contributors please add @flaviohenriquecbc for code |
|
I've put up a pull request to add @flaviohenriquecbc! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
When clicking on a wrapper element (e.g. div), it takes a screenshot of the inner elements.
Why:
The idea is to use less the toMatchSnapshot function. In this way, the tests will be more explicit. Something I noticed is that people tend to ignore the snapshots and just update them without thinking about it. This can be an elegant solution to avoid it.
How:
Run getSuggestedQuery to every child of the external wrapper.
Checklist: