Skip to content

fix: update chrome extension permissions #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2020
Merged

Conversation

smeijer
Copy link
Member

@smeijer smeijer commented Jun 16, 2020

What:
Changed the requested permissions of the chrome extension.

Why:
Google rejected the application 😞

How:
We were requesting both <all_urls> and activeTab, this seems to be redundant. Just activeTab should be enough.

Checklist:

  • Tests
  • Ready to be merged

I'm going to leave this PR open in draft mode, until the extension has been published.

The current changes have been resubmitted to the store.


current version: testing-playground-chrome-devtools-v1-0-1.zip

fixes #175

@smeijer smeijer self-assigned this Jun 17, 2020
@smeijer smeijer added the bug Something isn't working label Jun 17, 2020
@MichaelDeBoey
Copy link
Member

I think this one can be closed now? 🤔
https://twitter.com/meijer_s/status/1275736530175307780

@smeijer smeijer force-pushed the feature/fix-chrome-ext branch from 8c0a0a1 to c1d7a91 Compare June 24, 2020 11:31
@smeijer smeijer marked this pull request as ready for review June 24, 2020 11:32
@smeijer smeijer force-pushed the feature/fix-chrome-ext branch from c1d7a91 to f21d0ea Compare June 24, 2020 11:45
@smeijer smeijer changed the title fix: update chrome permissions fix: update chrome extension permissions Jun 24, 2020
@smeijer smeijer merged commit f45d6e4 into develop Jun 24, 2020
@smeijer smeijer deleted the feature/fix-chrome-ext branch June 24, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome Extension permissions needs to be fixed for approval
2 participants