fix: update chrome extension permissions #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this one can be closed now? 🤔 |
smeijer
force-pushed
the
feature/fix-chrome-ext
branch
from
8c0a0a1 to
c1d7a91
Compare
smeijer
force-pushed
the
feature/fix-chrome-ext
branch
from
c1d7a91 to
f21d0ea
Compare
smeijer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Changed the requested permissions of the chrome extension.
Why:
Google rejected the application 😞
How:
We were requesting both
<all_urls>andactiveTab, this seems to be redundant. JustactiveTabshould be enough.Checklist:
I'm going to leave this PR open in draft mode, until the extension has been published.
The current changes have been resubmitted to the store.
current version: testing-playground-chrome-devtools-v1-0-1.zip
fixes #175