Skip to content

Added React TDD examples with react-testing-library #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2018

Conversation

mbaranovski
Copy link
Contributor

@mbaranovski mbaranovski commented Apr 10, 2018

What:
Added React TDD examples with react-testing-library

Why:
Shows how to use react-testing-library when doing TDD in React

Checklist:

  • Documentation
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

kentcdodds
kentcdodds previously approved these changes Apr 10, 2018
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvelous! Thanks!

@kentcdodds
Copy link
Member

Your branch was outdated and had a conflict with the contributors list. You'll need to pull and run npx kcd-scripts contributors generate then commit and push the changes 👍 Thanks!

@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #50   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          18     18           
=====================================
  Hits           18     18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddcb1f1...8761386. Read the comment docs.

@mbaranovski
Copy link
Contributor Author

@aputhin must have pushed the code seconds before me ^_^

Should be fine now

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks!

@kentcdodds kentcdodds merged commit f671b69 into testing-library:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants