Skip to content

docs: fixes typo on the fireEvent example #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2018

Conversation

aputhin
Copy link
Contributor

@aputhin aputhin commented Apr 10, 2018

What:

Fixed a typo on the fireEvent so the examples on the README follow the same coding style.

Why:

Keep the docs consistent.

How:

  • added 'from react-testing-library' on the import for the said example
  • removed a semicolon after const spy = jest.fn() :)

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #49   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          18     18           
=====================================
  Hits           18     18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d3508...8c84a29. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I didn't actually see this typo! Normally the javascript in our markdown is autoformatted by prettier, but there's a syntax error in this code block which is why that semicolon is hanging around. Can you find and fix the syntax error too?

@aputhin
Copy link
Contributor Author

aputhin commented Apr 10, 2018

I think we found it xD thanks to @thiagopaiva99 who helped me find it (should add him to contributors aswell I guess?)

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better! Thanks :D

@kentcdodds kentcdodds merged commit ddcb1f1 into testing-library:master Apr 10, 2018
julienw pushed a commit to julienw/react-testing-library that referenced this pull request Dec 20, 2018
Part of the text was more appropriate for bug reports, and this commit adapts that to feature requests instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants