Skip to content

Update dependency eslint-config-prettier to v5 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2019

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Jun 15, 2019

This PR contains the following updates:

Package Type Update Change
eslint-config-prettier devDependencies major 4.3.0 -> 5.0.0

Release Notes

prettier/eslint-config-prettier

v5.0.0

Compare Source

  • Removed: [react/self-closing-comp]. This rule was added in v4.1.0 not
    because it conflicted with Prettier but because it was unnecessary when
    using Prettier. However, in v1.18.0 [Prettier stopped converting empty
    elements to self-closing elements][prettier-self-closing]. So the rule is
    not unnecessary anymore.

    If you use Prettier v1.17.1 or older you should be able to upgrade
    eslint-config-prettier to v5.0.0 without having to do anything else.

    If you use Prettier v1.18.0 or newer, you might get lint errors about for
    example changing <div></div> into <div />. You have two options:

    • Run eslint --fix if you prefer to enforce self-closing elements where
      possible. This should fix all the errors.
    • Add "react/self-closing-comp": "off" to your ESLint config if you use
      autofix from your editor and you face the same [issue as Prettier
      did][prettier-self-closing].
  • Changed: Node.js 6 is no longer officially supported, but v5.0.0 should
    still work with it.


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@codecov-io
Copy link

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #96   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          41     41           
  Branches        3      3           
=====================================
  Hits           41     41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc896c4...9860f94. Read the comment docs.

@mpeyper mpeyper merged commit 723fcd7 into master Jun 15, 2019
@renovate renovate bot deleted the renovate/eslint-config-prettier-5.x branch June 15, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants