Skip to content
This repository was archived by the owner on Jul 30, 2020. It is now read-only.

#72 update valid accessibility roles #74

Merged
merged 9 commits into from
Nov 4, 2019
Merged

#72 update valid accessibility roles #74

merged 9 commits into from
Nov 4, 2019

Conversation

ajsmth
Copy link
Contributor

@ajsmth ajsmth commented Nov 4, 2019

What:

Updated valid accessibility roles for the *ByRole queries

Why:
React Native has added additional accessibility properties:
https://facebook.github.io/react-native/docs/accessibility#accessibilityrole-ios-android

How:

Updated validRoles[] in role.js

Checklist:

  • Documentation added to the
    docs site
  • Typescript definitions updated
  • Tests
  • Ready to be merged

This references the issue raised #72

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #74   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines         268    268           
  Branches       67     67           
=====================================
  Hits          268    268
Impacted Files Coverage Δ
src/lib/queries/role.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ba416...a9b45b9. Read the comment docs.

@bcarroll22 bcarroll22 merged commit 540e6ad into testing-library:master Nov 4, 2019
@bcarroll22
Copy link
Collaborator

Thanks for all your help! @allcontributors please add @ajsmth for code and doc.

@allcontributors
Copy link
Contributor

@bcarroll22

I've put up a pull request to add @ajsmth! 🎉

@bcarroll22
Copy link
Collaborator

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants