Provide humane error messages for missing fireEvent() params #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds specific error message text when
element
/node
/event
params are missing forfireEvent()
Why:
In some cases you may be calling
fireEvent
without giving it an element, e.g.while it is discouraged, in some cases it is necessary to use
querySelector
or similar or you might be accessing aresults[0]
in an empty array returned byqueryAllBy*
.When you do that -
fireEvent()
will throw the good oldCannot convert undefined or null to object
, which means you need to go and look for what exactly happened.Providing a human readable, specific error message makes it easier to debug such failures.
How:
Throw a specific error after testing a condition.
Checklist:
docs site