test: Ensure broken node 16.9.0 isn't used #1028
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 135f09d:
|
Codecov Report
@@ Coverage Diff @@
## main #1028 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 916 916
Branches 286 286
=========================================
Hits 916 916
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| @@ -18,7 +18,8 @@ jobs: | |||
| # Otherwise we would not know if the problem is tied to the Node.js version | |||
| fail-fast: false | |||
| matrix: | |||
| node: [12, 14, 16] | |||
| # TODO: relax `'16.9.1'` to `16` once GitHub has 16.9.1 cached. 16.9.0 is broken due to https://github.com/nodejs/node/issues/40030 | |||
| node: [12, 14, '16.9.1'] | |||
There was a problem hiding this comment.
Can't use '^16.9.1' because codecov flags do not support carets:
Flags Must consist only of alphanumeric characters, '_', '-', or '.' and not exceed 45 characters
eps1lon
changed the title
|
🎉 This PR is included in version 8.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Fix GitHub jobs using node 16
Why:
They're currently broken due to using the cached and broken node version 16.9.0 which causes jest to fail due to
How:
Cherry-pick using a working version which works in a previously failing job: https://github.com/testing-library/dom-testing-library/runs/3574134403
Checklist:
[ ]Documentation added to thedocs site
[ ]TypeScript definitions updated