Skip to content

chore(ci): revert codeql improvements for CI resiliency #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025

Conversation

mdelapenya
Copy link
Member

What does this PR do?

It rolls back the two PRs added to reduce the GH runners, also retiring the codeql checks for javascript (not needed).

Why is it important?

We saw lots of failures in the codeql action, not allowing the lint stage to pass, blocking almost all PRs and merges.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner April 16, 2025 10:56
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Apr 16, 2025
@mdelapenya mdelapenya self-assigned this Apr 16, 2025
Copy link

netlify bot commented Apr 16, 2025

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit ef2188f
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67ff8cd073d279000861e905
😎 Deploy Preview https://deploy-preview-3112--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Member Author

merging as it's not affecting the tests

@mdelapenya mdelapenya merged commit 1be7b98 into testcontainers:main Apr 16, 2025
193 of 194 checks passed
@mdelapenya mdelapenya deleted the ci-resiliency branch April 16, 2025 11:05
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Apr 24, 2025
* main:
  feat(redis): add TLS support (testcontainers#3115)
  feat: add Docker Model Runner module (testcontainers#3106)
  feat: add toxiproxy module (testcontainers#3092)
  chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117)
  deps(aerospike): replace core module in go.mod (testcontainers#3116)
  chore(deps): bump golang.org/x/net from 0.36.0 to 0.38.0 in /modules and /examples (testcontainers#3114)
  chore(ci): revert codeql improvements for CI resiliency (testcontainers#3112)
  docs(socat): add missing version marker for new options (testcontainers#3111)
mdelapenya added a commit to xBlaz3kx/testcontainers-go that referenced this pull request Apr 24, 2025
* main:
  feat(postgres): add WithOrderedInitScripts for Postgres testcontainers (testcontainers#3121)
  feat(redis): add TLS support (testcontainers#3115)
  feat: add Docker Model Runner module (testcontainers#3106)
  feat: add toxiproxy module (testcontainers#3092)
  chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117)
  deps(aerospike): replace core module in go.mod (testcontainers#3116)
  chore(deps): bump golang.org/x/net from 0.36.0 to 0.38.0 in /modules and /examples (testcontainers#3114)
  chore(ci): revert codeql improvements for CI resiliency (testcontainers#3112)
  docs(socat): add missing version marker for new options (testcontainers#3111)
  deps: use pinned dependencies on GH actions (testcontainers#3110)
  chore(deps): bump jinja2 from 3.1.5 to 3.1.6 (testcontainers#3109)
  chore(ci): reduce GH runners usage by calling codeql in the lint stage (testcontainers#3108)
  deps(ci): use python 3.13 on Netlify deployments (testcontainers#3107)
mdelapenya added a commit to jm96441n/testcontainers-go that referenced this pull request Apr 24, 2025
* main:
  feat(postgres): add WithOrderedInitScripts for Postgres testcontainers (testcontainers#3121)
  feat(redis): add TLS support (testcontainers#3115)
  feat: add Docker Model Runner module (testcontainers#3106)
  feat: add toxiproxy module (testcontainers#3092)
  chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117)
  deps(aerospike): replace core module in go.mod (testcontainers#3116)
  chore(deps): bump golang.org/x/net from 0.36.0 to 0.38.0 in /modules and /examples (testcontainers#3114)
  chore(ci): revert codeql improvements for CI resiliency (testcontainers#3112)
  docs(socat): add missing version marker for new options (testcontainers#3111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant