feat: Docker shell commands #710
Open
+380
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Execute shell commands inside Docker container when build_in_docker=true - Add automatic Docker image pull if not found locally - Fix critical bug: handle query=None in BuildPlanManager.execute() - Add 4 unit tests for Docker and host execution paths - Update README with shell commands documentation and example - Add example module demonstrating Docker shell commands This allows users to run package managers and build tools that are only available in the container environment. All 11 tests passing (7 existing + 4 new).
- Apply ruff formatting fixes - Update example documentation with terraform-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for executing shell commands inside Docker containers when
build_in_docker = true.Previously, shell commands specified in the
commandsparameter were always executed on the host machine, even when Docker builds were enabled.Motivation and Context
When using
build_in_docker = true, users often need to run commands (like package managers or build tools) thatare only available in the Lambda runtime environment. For example, installing Python packages with native
extensions that need to be compiled for the specific Lambda runtime.
#307
Breaking Changes
No breaking changes. This is fully backward compatible:
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)package_with_docker_shell_commandsexample inexamples/build-package/main.tfexamples/*projectscdcommandspre-commit run -aon my pull request