fix: Update linuxParameters
conditional and defaults
#330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The defaults for
linuxParameters
were not allowing the conditional here to evaluate.linuxParameters
would always containinitProcessEnabled = false
since it was a default, unless the user explicitly set this parameter.Additionally, the
for
loop to remove null values has to be done on the variable rather than the local variable since the variable has the object types defined. If we just removed the defaults and left thefor
loop to remove null values from the local values, then object defaults would benull
and the map would merge with null values and result in null andinitProcessEnabled
wouldn't be set at all unless explicitly defined.Motivation and Context
Stems from: #319 (comment)
Breaking Changes
No.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request