Skip to content

Used string manipulation instead of templating to remove characters from SAN #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Used string manipulation instead of templating to remove characters from SAN #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
locals {
// Get distinct list of domains and SANs
distinct_domain_names = distinct(concat([var.domain_name], data.template_file.breakup_san.*.rendered))
distinct_domain_names = distinct(
concat(
[var.domain_name],
split(":", replace(join(":", var.subject_alternative_names), "*.", ""))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be this instead:

distinct(
  split(":", replace(join(":", concat(var.domain_name, var.subject_alternative_names)), "*.", ""))

Because var.domain_name might also be a wildcard, so that needs to be included in the whole *. filtering.

)
)

// Copy domain_validation_options for the distinct domain names
validation_domains = [for k, v in aws_acm_certificate.this[0].domain_validation_options : tomap(v) if contains(local.distinct_domain_names, v.domain_name)]
Expand Down