Replace d3.selection.html with .text. #5840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its usage could lead to XSS and it's not compatible with Trusted Types.
bmd3k
approved these changes
Aug 4, 2022
Contributor
bmd3k
left a comment
bmd3k
left a comment
There was a problem hiding this comment.
Thanks Jakub. I audited current usage of this function and it looks like we only use text for these menu items. So the change shouldn't unexpectedly break anything.
yatbear
pushed a commit
that referenced
this pull request
Aug 5, 2022
Its usage could lead to XSS and it's not compatible with Trusted Types.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
Its usage could lead to XSS and it's not compatible with Trusted Types.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Its usage could lead to XSS and it's not compatible with Trusted Types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its usage could lead to XSS and it's not compatible with Trusted Types.