Serialize multiqubit #447
Merged
Serialize multiqubit #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have some time to look at this in detail tomorrow |
zaqqwerty
suggested changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses step 2 in #422 .
The final step is to link these gates into the new qsim simulator. Right now most of the C++ code still ignore
control_qubitsandcontrol_valuesproto fields.With the help of the
DelayedAssignmentGatethis change adds thecontrol_qubitsandcontrol_valuesfield to every gates args field. Updates all previous tests to use controlled operations as well and added a test for invalidcontrol_qubits. Plz review closely, I'm always a little concerned when touching code inserializer.pysince it's used so widely.