Qsim upgrade #445
Merged
Qsim upgrade #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaqqwerty
suggested changes
Dec 7, 2020
| State scratch = StateSpace(largest_nq, tfq_for).CreateState(); | ||
| Simulator sim = Simulator(tfq_for); | ||
| StateSpace ss = StateSpace(tfq_for); | ||
| auto sv = StateSpace(tfq_for).Create(largest_nq); |
There was a problem hiding this comment.
Create(unsigned num_qubits) returns a Vector with freshly allocated memory, so no need to call StateSpace(tfq_for) again, rather can just use ss for these
a feedback.
jaeyoo
pushed a commit
to jaeyoo/quantum
that referenced
this pull request
Mar 30, 2023
Fix ASAN error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @95-orion-martin , @we-taper
Finishes step 1 in #422
Thematically speaking only a couple of renames and argument movements.
StateSpacenow containsVectorSpace.CreateState->Createand StateSpaces and Simulators no longer have qubit size associated with them so we don't have to create new StateSpace and Simulator objects everytime a state vector size changed.