Wrap the IOTensor function as a callable class #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Member
Author
|
This is a refactor without any API change or new addition, so will just merge shortly. |
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
* Remove step arg as it could not be supported in C++ anyway Signed-off-by: Yong Tang <[email protected]> * Fix audio and lmdb Signed-off-by: Yong Tang <[email protected]> * Fix prometheus Signed-off-by: Yong Tang <[email protected]> * Fix Kafka Signed-off-by: Yong Tang <[email protected]> * Fix CSV Signed-off-by: Yong Tang <[email protected]> * Fix HDF5 Signed-off-by: Yong Tang <[email protected]> * Fix JSON Signed-off-by: Yong Tang <[email protected]> * Pylint fix Signed-off-by: Yong Tang <[email protected]> * Fix feather Signed-off-by: Yong Tang <[email protected]> * LMDB naming change Signed-off-by: Yong Tang <[email protected]> * Remove the need to specify label Signed-off-by: Yong Tang <[email protected]> * Fix Kafka Signed-off-by: Yong Tang <[email protected]> * Make output name consistent Signed-off-by: Yong Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wrap the IOTensor function as a callable class, so that it is easy to manage. In the past, when IOTensor function is called, it expect several non-regular args such as component, column names, label field etc. This makes it hard to manage.
This PR wrap the IOTensor function as a callable class and any non-input are part of the class member. At the end IOTensor expect a function of :
In this way, all functions could be passed around with the same type of processing.
This PR also removed
steparg as we could not support it anyway.Signed-off-by: Yong Tang [email protected]