-
Notifications
You must be signed in to change notification settings - Fork 306
More changes for BigQuery connector #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
@vlasenkoalexey I think the last commit was using your local machine's |
|
@vlasenkoalexey Looks like the CLA still has some issues, I think the I think if you squash the last two commit then the second-to-last commit of "more style tweaks" will collapse with the last commit and the author issue will be fixed. Alternatively I think the following may also work: $ git rebase -i HEAD~2
# change the first line of "pick more style tweaks" to "edit more style tweaks"
# then update author:
$ git commit --amend --reset-author
$ git rebase --continue |
a201c12 to
1870e5b
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@yongtang thanks for the pointer. Indeed looks like I committed one of the changes from Docker container and just reverting it didn't help. |
yongtang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
* Fixing Dockerfile * Returning dataset in a form of Dictionary from BigQuery connector * Adding NULL fields support to BigQuery connector * python style tweak * more style tweaks * Style tweaks, comming from google account
… 0.7.1 (#556) * adding README document describing how to use BigQuery connector (#467) * adding README document describing how to use BigQuery connector * Fixing BigQuery connector package definition, and updating README.md accordingly * More changes for BigQuery connector (#490) * Fixing Dockerfile * Returning dataset in a form of Dictionary from BigQuery connector * Adding NULL fields support to BigQuery connector * python style tweak * more style tweaks * Style tweaks, comming from google account * Properly setting row_restriction in createReadSessionRequest and updating sample accordingly (#529) * updating version 0.7.0 -> 0.7.1 * locking TF version to 1.14 * linter fix
* Fixing Dockerfile * Returning dataset in a form of Dictionary from BigQuery connector * Adding NULL fields support to BigQuery connector * python style tweak * more style tweaks * Style tweaks, comming from google account
@sshrdp FYI
@googlebot I fixed it. - not sure why last commit wasn't recognized.