Skip to content

Conversation

@vlasenkoalexey
Copy link
Contributor

@vlasenkoalexey vlasenkoalexey commented Sep 18, 2019

  • Fixed typo in the Dockerfile
  • Added NULL fields support to BigQuery connector
  • Returning dataset in a form of Dictionary from BigQuery connector

@sshrdp FYI

@googlebot I fixed it. - not sure why last commit wasn't recognized.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@vlasenkoalexey
Copy link
Contributor Author

@googlebot I fixed it.

@yongtang
Copy link
Member

@vlasenkoalexey I think the last commit was using your local machine's root user as the author. If you use git commit --amend --reset-author it likely will fix the issue I believe.

@yongtang
Copy link
Member

@vlasenkoalexey Looks like the CLA still has some issues, I think the second-to-last commit ("more style tweaks") may need to be updated.

I think if you squash the last two commit then the second-to-last commit of "more style tweaks" will collapse with the last commit and the author issue will be fixed.

Alternatively I think the following may also work:

$ git rebase -i HEAD~2
# change the first line of "pick more style tweaks" to "edit more style tweaks" 
# then update author:
$ git commit --amend --reset-author
$ git rebase --continue

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@vlasenkoalexey
Copy link
Contributor Author

@yongtang thanks for the pointer. Indeed looks like I committed one of the changes from Docker container and just reverting it didn't help.

Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@yongtang yongtang merged commit 55d9750 into tensorflow:master Sep 19, 2019
vlasenkoalexey added a commit to vlasenkoalexey/io that referenced this pull request Oct 18, 2019
* Fixing Dockerfile

* Returning dataset in a form of Dictionary from BigQuery connector

* Adding NULL fields support to BigQuery connector

* python style tweak

* more style tweaks

* Style tweaks, comming from google account
yongtang pushed a commit that referenced this pull request Oct 18, 2019
… 0.7.1 (#556)

* adding README document describing how to use BigQuery connector (#467)

* adding README document describing how to use BigQuery connector

* Fixing BigQuery connector package definition, and updating README.md accordingly

* More changes for BigQuery connector (#490)

* Fixing Dockerfile

* Returning dataset in a form of Dictionary from BigQuery connector

* Adding NULL fields support to BigQuery connector

* python style tweak

* more style tweaks

* Style tweaks, comming from google account

* Properly setting row_restriction in createReadSessionRequest and updating sample accordingly (#529)

* updating version 0.7.0 -> 0.7.1

* locking TF version to 1.14

* linter fix
i-ony pushed a commit to i-ony/io that referenced this pull request Feb 8, 2021
* Fixing Dockerfile

* Returning dataset in a form of Dictionary from BigQuery connector

* Adding NULL fields support to BigQuery connector

* python style tweak

* more style tweaks

* Style tweaks, comming from google account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants