Skip to content

Conversation

@BryanCutler
Copy link
Member

This PR makes use of the ArrowRandomAccessFile from TFIO that wraps a TF RandomAccessFile to read Arrow Feather files in the ArrowFeatherDataset. By using this interface, it makes it possible to load cloud storage files, as discussed in #404 (comment).

@BryanCutler BryanCutler requested a review from yongtang August 13, 2019 22:34
@BryanCutler
Copy link
Member Author

BryanCutler commented Aug 13, 2019

@yongtang please have a look when you can. This is an initial step to use the ArrowRandomAccessFile interface in the current ArrowFeatherDataset. This can be refactored later into a primitive op, and then support loading from memory also. cc @terrytangyuan

Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@yongtang yongtang merged commit 0ef0f21 into tensorflow:master Aug 14, 2019
@BryanCutler BryanCutler deleted the arrow-feather-use-RandomAccessSizedFile branch August 15, 2019 18:14
i-ony pushed a commit to i-ony/io that referenced this pull request Feb 8, 2021
…w#418)

* Add feather test with prefix

* Use ArrowRandomAccessFile for reading Feather files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants