Rework on PrometheusDataset #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the effort to reduce the dedicated C++ implementation of Dataset and replace with primitive ops that could be used both with tf.data, and with Tensor. There are some room for enhancement, for example, a timestamp could be passed to read_prometheus and each call will only read a small slice of the data to tensor. Will have follow up PRs later to implement that. Signed-off-by: Yong Tang <[email protected]>
|
Plan to merge this PR shortly. |
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
This is part of the effort to reduce the dedicated C++ implementation of Dataset and replace with primitive ops that could be used both with tf.data, and with Tensor. There are some room for enhancement, for example, a timestamp could be passed to read_prometheus and each call will only read a small slice of the data to tensor. Will have follow up PRs later to implement that. Signed-off-by: Yong Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the effort to reduce the dedicated C++
implementation of Dataset and replace with primitive ops
that could be used both with tf.data, and with Tensor.
See #382 and #366 for related discussions.
There are some room for enhancement, for example,
a timestamp could be passed to read_prometheus
and each call will only read a small slice of the data
to tensor. Will have follow up PRs later to implement that.
Signed-off-by: Yong Tang [email protected]