Allow running lint concurrently with Travis CI build #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR the Travis Ci build was set in a way such that lint runs before any other tests (and fails immediately). Think it makes sense to allow running lint concurrently with other tests, so that people could fix all build failures (including lint) in one update. Signed-off-by: Yong Tang <[email protected]>
terrytangyuan
approved these changes
Jun 17, 2019
BryanCutler
approved these changes
Jun 17, 2019
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
Before this PR the Travis Ci build was set in a way such that lint runs before any other tests (and fails immediately). Think it makes sense to allow running lint concurrently with other tests, so that people could fix all build failures (including lint) in one update. Signed-off-by: Yong Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR the Travis Ci build was set in a way such that
lint runs before any other tests (and fails immediately). See for example PR #303.
Think it makes sense to allow running lint concurrently with
other tests, so that people could fix all build failures (including lint)
in one update.
Signed-off-by: Yong Tang [email protected]