Add batch support for VideoDataset and support reading from streams #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_video_eager.py
Outdated
| video_path = os.path.join( | ||
| os.path.dirname(os.path.abspath(__file__)), "test_video", "small.mp4") | ||
|
|
||
| video_path = "file://" + video_path |
Member
There was a problem hiding this comment.
Consider combining with the above two lines?
tests/test_video.py
Outdated
| video_path = os.path.join( | ||
| os.path.dirname(os.path.abspath(__file__)), "test_video", "small.mp4") | ||
|
|
||
| video_path = "file://" + video_path |
| """A Video File Dataset that reads the video file.""" | ||
|
|
||
| def __init__(self, filename): | ||
| def __init__(self, filename, batch=None): |
Member
There was a problem hiding this comment.
Add docstring for this and a note on the relation between dataset's own batch() since I think users would definitely be confused about this.
Signed-off-by: Yong Tang <[email protected]>
Fixes 144 Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Member
Author
|
@terrytangyuan The PR has been updated, please take a look. |
terrytangyuan
approved these changes
Jun 16, 2019
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
…ensorflow#295) * Add batch support for VideoDataset Signed-off-by: Yong Tang <[email protected]> * Support read video from stream (instead of file name). Fixes 144 Signed-off-by: Yong Tang <[email protected]> * Address review feedback Signed-off-by: Yong Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix adds batch support for VideoDataset and support reading from streams.
This fix also fixes #144.
Signed-off-by: Yong Tang [email protected]