Add prometheus dataset support #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongtang
force-pushed
the
prometheus
branch
6 times, most recently
from
4e1c11a to
87f775d
Compare
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # ============================================================================== | ||
| """PrometheusInput.""" |
There was a problem hiding this comment.
Should be PrometheusDataset
| """Create a Prometheus Reader. | ||
|
|
||
| Args: | ||
| filename: A `tf.string` tensor containing one or more filenames. |
There was a problem hiding this comment.
Missing docs for the other args
tests/test_prometheus.py
Outdated
| import tensorflow_io.prometheus as prometheus_io # pylint: disable=wrong-import-position | ||
|
|
||
| if sys.platform == "darwin": | ||
| pytest.skip("pubsub is not supported on macOS yet", allow_module_level=True) |
There was a problem hiding this comment.
Remove unnecessary pubsub reference here
tests/test_prometheus.py
Outdated
| # License for the specific language governing permissions and limitations under | ||
| # the License. | ||
| # ============================================================================== | ||
| """Tests for Prometheus Input.""" |
| output_types=self.output_types, | ||
| output_shapes=self.output_shapes) | ||
|
|
||
| @property |
There was a problem hiding this comment.
Should we implement all future datasets based on 2.0 tf.data.Dataset?
yongtang
force-pushed
the
prometheus
branch
3 times, most recently
from
e0d858e to
50a5d9e
Compare
yongtang
force-pushed
the
prometheus
branch
2 times, most recently
from
f24c187 to
d5aac20
Compare
This fix adds prometheus dataset support, with prometheus library in golang. Signed-off-by: Yong Tang <[email protected]>
|
@BryanCutler @terrytangyuan The PR has been updated and now all tests passed. There are several motivations to have a prometheus as data input.
The test case is wired up with CoreDNS as a example server with Prometheus scraping the metrics from CoreDNS. tensorflow-io connects to Prometheus' endpoint to get metrics and delivers as tf.data pipeline. Should be possible to work with tf.keras directly for training or inference. Also cc @ihac in case you are interested in Prometheus+CoreDNS. |
terrytangyuan
approved these changes
Jun 17, 2019
BryanCutler
approved these changes
Jun 17, 2019
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
This fix adds prometheus dataset support, with prometheus library in golang. Signed-off-by: Yong Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix adds prometheus dataset support, with prometheus library in golang.
This fix fixes #246.
Signed-off-by: Yong Tang [email protected]