Add TextInput support #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The build fail with Ubuntu 16.04 and 18.04, likely caused by the gcc version mismatch of the binary in tensorflow. The gdb debug shows the segmentation fault happens in |
yongtang
force-pushed
the
text_input
branch
2 times, most recently
from
355a2fc to
54804ba
Compare
Member
Author
|
Removed building on Ubuntu 16.04 and 18.04 with tensorflow binaries, as it will not work. Our CI is still fully covered, as we build our binary on Ubuntu 14.04, and test on Ubuntu 16.04 and 18.04. This PR is ready for review. /cc @terrytangyuan |
Member
Author
|
@terrytangyuan All test finally passed 🎉 |
Member
|
Oops seems like there's conflict from the recently merged PR. Could you resolve it? |
This PR add TextInput support, with expanded archive support. Signed-off-by: Yong Tang <[email protected]>
with the same version of gcc with tensorflow Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Member
Author
|
@terrytangyuan The PR has been rebased and all tests passed now. |
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
Add TextInput support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add TextInput support, with expanded archive support.
Signed-off-by: Yong Tang [email protected]