Skip to content

Conversation

@kvignesh1420
Copy link
Member

Currently, we push latest, latest-devel and nightly tags to the docker registry. However, we do not have a tag which captures the version of the release. This PR addresses the issue by tagging the images with version obtained from setup.py

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though should we tag previously released versions as well?

@kvignesh1420
Copy link
Member Author

kvignesh1420 commented Oct 19, 2020

@terrytangyuan the credentials are with @yongtang. We can use the tools/docker/cpu.Dockerfile to pass the tfio version and build. This is a one-time thing though.

Not sure if we should use GH actions for previous releases.

@kvignesh1420 kvignesh1420 merged commit 2e15218 into tensorflow:master Oct 20, 2020
@kvignesh1420 kvignesh1420 deleted the version-tag branch October 20, 2020 04:04
@yongtang
Copy link
Member

@kvignesh1420 @terrytangyuan Sorry for the late response as I was occupied heavily recently. I will try to see if I can push the early docker images. (I tried to see if we can have a team account so that anyone from the team can push the image, but looks like docker hub just had too many restrictions).

@kvignesh1420
Copy link
Member Author

kvignesh1420 commented Oct 20, 2020

@yongtang no issues. Few things to note if you are pushing the earlier versions:

  • Use the version number as the tag instead of adding v to the beginning. (for ex: 0.15.0 instead of v0.15.0). This way we can be in sync with the tensorflow tags
  • Remove the existing tag v0.15.0
  • Delete the old account https://hub.docker.com/r/tfiocontainer/tfio

@kvignesh1420 kvignesh1420 mentioned this pull request Oct 20, 2020
15 tasks
@yongtang
Copy link
Member

Pushed old releases from 0.8.0 => 0.14.0 to docker hub. I didn't push earlier versions than 0.8.0 as 0.8.0 was the version tied to TF 1.15. We want to give user an option of TF 1.x but we don't want to go any earlier 1.x versions.

@kvignesh1420
Copy link
Member Author

@yongtang thanks!

i-ony pushed a commit to i-ony/io that referenced this pull request Feb 8, 2021
zheolong pushed a commit to zheolong/io-1 that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants