Skip to content

Conversation

Ankuraxz
Copy link

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no to not pull in to main branch, I think label Mar 19, 2020
@Ankuraxz
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes to pull into main branch, I think? and removed cla: no to not pull in to main branch, I think labels Mar 19, 2020
@Ankuraxz
Copy link
Author

Issue: #18

Code Migrated to TF2.x

@Ankuraxz
Copy link
Author

Someone please look on this PR

@Ankuraxz
Copy link
Author

Can anyone help me with import/copybara

@merrcury
Copy link

Hi Ankuraxz,

  • You can move Collab_tutorial_on_GAN_using_tf2_x.ipynb to tensorflow_gan/examples/colab_notebooks/
  • Talking about tensorflow_gan/Image_GAN/Image_GAN.md. It does not seem necessary. You should document about code in the notebook itself.
  • Please insert LICENSE snippet at starting of file. eg. (Below given is just example)

# Copyright 2018 The TensorFlow GAN Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# ==============================================================================
  • I think you can disregard copybara for a while. Read about copybara from here

@Ankuraxz
Copy link
Author

Okk thanks 👍


In response to Issue "Colab Tutorial Not TF 2.x Compatible tensorflow#18" on tensorflow/gan tensorflow#18

Collab Tutorial using tf 2.x
@Ankuraxz
Copy link
Author

Issue: #18

Code Migrated to TF2.x

This general model can be applied to any kind of Image dataset, like Handwritten digits, Cifar10, Fashion-MNIST etc. Find more about datasets here: https://www.tensorflow.org/api_docs/python/tf/keras/datasets
@Ankuraxz
Copy link
Author

Issue: #18

Code Migrated to TF2.x

@Ankuraxz
Copy link
Author

@merrcury Thank you very much for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes to pull into main branch, I think?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants