This repository was archived by the owner on Jul 10, 2025. It is now read-only.
RFC: Setting GRPC_FAIL_FAST to use_caller by Default #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoyuz
requested review from
ematejska,
ewilderj and
theadactyl
as code owners
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 19, 2021
For details: tensorflow/community#355 PiperOrigin-RevId: 363809453 Change-Id: I336219c0ce36bb4e45ded8836cf6c15d306c4db2
|
This has been approved. |
ematejska
added
RFC: Accepted
ematejska
approved these changes
Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feedback phase will be open for two weeks until 2021-03-18
Objective
We propose to set the default value of the
GRPC_FAIL_FASTenvironment variable touse_caller. This change prevents TensorFlow distributed jobs from hanging indefinitely due to task failures, and allows users and TF libraries (e.g., distribution strategies) to handle the connection errors for better failure and preemption recovery.