Skip to content

Conversation

seanpmorgan
Copy link
Member

@seanpmorgan seanpmorgan commented Jan 30, 2020

Closes #864 #965

@seanpmorgan seanpmorgan added the blocked Pending something elses completion label Jan 30, 2020
@seanpmorgan seanpmorgan requested a review from a team as a code owner January 30, 2020 01:09
@boring-cyborg boring-cyborg bot added the build label Jan 30, 2020
@seanpmorgan
Copy link
Member Author

Since this is major request and large change we should consider a 0.8 release after we finish PRs that are finalizing.

@seanpmorgan seanpmorgan changed the title [WIP] Remove hard installation dep [WIP] BLD: Remove hard installation dep Jan 30, 2020
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR, happy to see it :)

@boring-cyborg boring-cyborg bot added the test-cases Related to Addons tests label Jan 30, 2020
@seanpmorgan seanpmorgan changed the title [WIP] BLD: Remove hard installation dep BLD: Remove hard installation dep Jan 30, 2020
@seanpmorgan seanpmorgan removed the blocked Pending something elses completion label Jan 30, 2020
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

@gabrieldemarmiesse
Copy link
Member

Thanks for the pull request, looks good to me!

@gabrieldemarmiesse gabrieldemarmiesse merged commit 37f0fd9 into tensorflow:master Jan 30, 2020
@seanpmorgan seanpmorgan deleted the bld-remove-dependency branch January 30, 2020 16:48
@seanpmorgan seanpmorgan mentioned this pull request Jan 31, 2020
failure-to-thrive pushed a commit to failure-to-thrive/addons that referenced this pull request Feb 1, 2020
* Remove hard installation dep

* Update TF required

* Update build for no dependency

* Move to utils

* Remove sys exit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build cla: yes test-cases Related to Addons tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tensorflow-cpu is ignored when installing tensorflow-addons

3 participants