Remove tf function where unecessary

[seanpmorgan]

Closes #807

Removed from:

• Functions that are simple calls to a custom op
• Functions that are likely to be re-traced

[WindQAQ]

Just a note, have to update the README.md about tf.function description.

[WindQAQ]

Thanks for cleanup! My only concern is that test_unknown_shape for image tests is designed for tf.data.Dataset. If we get rid of tf.function, will it always be compatible for tf.data.Dataset? Moreover, a old thread tensorflow/tensorflow#27811 mentioned that tf.function will be apply automatically for tf.data.Dataset.map for TF2.0.

A trivial test is to use something like

fn = tf.function(dist_ops.euclidean_dist_transform).get_concrete_function(
                 tf.TensorSpec(None, tf.uint8))

to make sure it would be compatible with tf.data.Dataset.

What do you think, Sean?

#330 #332

[seanpmorgan]

Thanks for cleanup! My only concern is that test_unknown_shape for image tests is designed for tf.data.Dataset. If we get rid of tf.function, will it always be compatible for tf.data.Dataset? Moreover, a old thread tensorflow/tensorflow#27811 mentioned that tf.function will be apply automatically for tf.data.Dataset.map for TF2.0.

A trivial test is to use something like

fn = tf.function(dist_ops.euclidean_dist_transform).get_concrete_function(
                 tf.TensorSpec(None, tf.uint8))

to make sure it would be compatible with tf.data.Dataset.

What do you think, Sean?

#330 #332

Thanks good catch.. i've added them back. I was also thinking we should have subpackage test suites similar to keras.layer_test. I'll create a seperate issue for that.

[WindQAQ]

Thanks!