Skip to content

FIX: RNN support for weight norm and remove() #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 2, 2020
Merged

FIX: RNN support for weight norm and remove() #819

merged 4 commits into from
Jan 2, 2020

Conversation

@Squadrick
Copy link
Member

@Squadrick Squadrick commented Dec 30, 2019 •
edited
Loading

Continuation of #769

@Squadrick Squadrick changed the title FIX: RNN support for weight norm FIX: RNN support for weight norm and remove() Dec 31, 2019
seanpmorgan
seanpmorgan requested changes Dec 31, 2019
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Small change requested and fix lint. Otherwise LGTM

@Squadrick Squadrick added discussion needed wip Work in-progress and removed discussion needed wip Work in-progress labels Jan 1, 2020
@Squadrick Squadrick mentioned this pull request Jan 1, 2020
Closed
seanpmorgan
seanpmorgan approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanpmorgan seanpmorgan merged commit 510aa3c into tensorflow:master Jan 2, 2020
@Squadrick Squadrick mentioned this pull request Feb 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

@facaiy facaiy Awaiting requested review from facaiy

Assignees

No one assigned

Labels

cla: yes layers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to remove Weight_Normalization?

3 participants

@Squadrick @seanpmorgan @googlebot