Skip to content

Don't build parse_time till TF r2.1 #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2019
Merged

Don't build parse_time till TF r2.1 #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69267b0
Don't build parse_time till TF r2.1
Squadrick Nov 21, 2019
2131faa
Fix TODO, and BUILD
Squadrick Nov 21, 2019
dfe6e81
Remove .py file from build target
Squadrick Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions tensorflow_addons/custom_ops/text/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ custom_op_library(
],
)

custom_op_library(
name = "_parse_time_op.so",
srcs = [
"cc/kernels/parse_time_kernel.cc",
"cc/ops/parse_time_op.cc",
],
)
# TODO: https://github.com/tensorflow/addons/issues/663
# custom_op_library(
# name = "_parse_time_op.so",
# srcs = [
# "cc/kernels/parse_time_kernel.cc",
# "cc/ops/parse_time_op.cc",
# ],
# )
30 changes: 16 additions & 14 deletions tensorflow_addons/text/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,17 @@ licenses(["notice"]) # Apache 2.0

package(default_visibility = ["//visibility:public"])

# TODO: https://github.com/tensorflow/addons/issues/663
py_library(
name = "text",
srcs = ([
"__init__.py",
"crf.py",
"parse_time_op.py",
# "parse_time_op.py",
"skip_gram_ops.py",
]),
data = [
"//tensorflow_addons/custom_ops/text:_parse_time_op.so",
# "//tensorflow_addons/custom_ops/text:_parse_time_op.so",
"//tensorflow_addons/custom_ops/text:_skip_gram_ops.so",
"//tensorflow_addons/utils",
],
Expand Down Expand Up @@ -44,15 +45,16 @@ py_test(
],
)

py_test(
name = "parse_time_op_test",
size = "small",
srcs = [
"parse_time_op_test.py",
],
main = "parse_time_op_test.py",
srcs_version = "PY2AND3",
deps = [
":text",
],
)
# TODO: https://github.com/tensorflow/addons/issues/663
# py_test(
# name = "parse_time_op_test",
# size = "small",
# srcs = [
# "parse_time_op_test.py",
# ],
# main = "parse_time_op_test.py",
# srcs_version = "PY2AND3",
# deps = [
# ":text",
# ],
# )
3 changes: 2 additions & 1 deletion tensorflow_addons/text/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,6 @@
from tensorflow_addons.text.skip_gram_ops import skip_gram_sample
from tensorflow_addons.text.skip_gram_ops import skip_gram_sample_with_text_vocab

# TODO: https://github.com/tensorflow/addons/issues/663
# Parse Time
from tensorflow_addons.text.parse_time_op import parse_time
# from tensorflow_addons.text.parse_time_op import parse_time