Skip to content

Conversation

@Squadrick
Copy link
Member

Fixes #623

@Squadrick
Copy link
Member Author

FAIL: Found 4 non-whitelited pylint errors:
tensorflow_addons/text/crf_test.py:212: [E1136(unsubscriptable-object), CrfTest.testCrfLogLikelihood] Value 'inputs.shape' is unsubscriptable

tensorflow_addons/text/crf_test.py:213: [E1136(unsubscriptable-object), CrfTest.testCrfLogLikelihood] Value 'inputs.shape' is unsubscriptable

tensorflow_addons/text/crf_test.py:244: [E1136(unsubscriptable-object), CrfTest.testViterbiDecode] Value 'inputs.shape' is unsubscriptable

tensorflow_addons/text/crf_test.py:245: [E1136(unsubscriptable-object), CrfTest.testViterbiDecode] Value 'inputs.shape' is unsubscriptable

Pylint fails for python3, but it works fine for python2. Any idea why the error arises?

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Regarding the lint error it looks like it might be upstream bug in pylint:
pylint-dev/pylint#3139

For now could you just disable the error by surrounding with

# pylint: disable=E1136
...
# pylint: enable=E1136

@Squadrick
Copy link
Member Author

@seanpmorgan Yeah, that fixed it. I've added a TODO to remove the pylint directives once the issue is resolved.

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix!

@seanpmorgan seanpmorgan merged commit 1e86eec into tensorflow:master Nov 5, 2019
@Squadrick Squadrick deleted the crf-fix branch November 5, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvalidArgumentError caused by int32 / int64 in crf_log_likelihood

4 participants