Skip to content

Conversation

@AndreasMadsen
Copy link
Contributor

  • ENH: Including a Sparsemax Later and A SparsemaxLoss class

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great. Few things that need changes though

@AndreasMadsen
Copy link
Contributor Author

Should be fixed.

@facaiy
Copy link
Member

facaiy commented Mar 4, 2019

ignore it, my mistake.

@seanpmorgan
Copy link
Member

Apologies for the fast merges in front of this issue. We had to finalize our styling etc.
@AndreasMadsen Could you please resolve conflicts and run make code-format

* ENH: Including a Sparsemax Later and A SparsemaxLoss class
@AndreasMadsen
Copy link
Contributor Author

Linting should be okay now.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Mar 4, 2019
@seanpmorgan seanpmorgan merged commit b6a1091 into tensorflow:master Mar 4, 2019
Squadrick pushed a commit to Squadrick/addons that referenced this pull request Mar 26, 2019
* ENH: implement sparsemax and sparsemax_loss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants