Skip to content

Conversation

@facaiy
Copy link
Member

@facaiy facaiy commented Mar 3, 2019

Related with #16

Fix all codes style.

# Format all code files:
bash tools/ci_build/code_format.sh --in-place

@facaiy facaiy force-pushed the CLN/auto_format_all_codes branch from bf1da09 to edb2fa6 Compare March 3, 2019 09:33
@facaiy facaiy added the style Related to repository's style label Mar 3, 2019
@facaiy facaiy force-pushed the CLN/auto_format_all_codes branch from edb2fa6 to 878d2b7 Compare March 4, 2019 07:31
@facaiy facaiy changed the title WIP: use code_format.sh to format all files use code_format.sh to format all files Mar 4, 2019
@facaiy facaiy mentioned this pull request Mar 4, 2019
docformatter >= 1.1
yapf >= 0.26.0
# TODO: Upgrade pylint to 2.0 when python >= 3.4
pylint == 1.6.4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.6.4 is too out-of-date. Hope that we could upgrade pylint to 2.0 later.

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@seanpmorgan seanpmorgan merged commit 440bd6a into tensorflow:master Mar 4, 2019
@facaiy facaiy deleted the CLN/auto_format_all_codes branch March 4, 2019 21:06
Squadrick pushed a commit to Squadrick/addons that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes style Related to repository's style

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants