Skip to content

Allow manual memory reset in AttentionMechanism #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 30, 2019
Merged

Allow manual memory reset in AttentionMechanism #547

merged 6 commits into from
Sep 30, 2019

Conversation

kazemnejad
Copy link
Contributor

@kazemnejad kazemnejad commented Sep 28, 2019 •
edited
Loading

Add support for manual memory reset by removing the _memory_initialized cache on mechanism(..., setup_memory=True) call

Fixed: #535

qlzh727
qlzh727 reviewed Sep 30, 2019
View reviewed changes
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, just some comments about the test.

@guillaumekln guillaumekln merged commit df256b9 into tensorflow:master Sep 30, 2019
@guillaumekln
Copy link
Contributor

Thanks @kazemnejad!

@qlzh727
Copy link
Member

qlzh727 commented Sep 30, 2019

Indeed. Thanks @kazemnejad for the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qlzh727 qlzh727 qlzh727 approved these changes

@guillaumekln guillaumekln Awaiting requested review from guillaumekln guillaumekln is a code owner

Assignees

No one assigned

Labels

cla: yes seq2seq

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AttentionMachanism is not compatible with Eager Execution

5 participants

@kazemnejad @guillaumekln @qlzh727 @googlebot @kokoro-team