-
Notifications
You must be signed in to change notification settings - Fork 617
[DO NOT MERGE]: Testing PR infrastructure. #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@seanpmorgan Trying to get this resolved as fast as possible. |
|
@av8ramit Should @seanpmorgan be able to click through to see Py2 results now? @seanpmorgan , can you see them? |
|
Py2 yes, Py3 no. Seems like its close 😄 |
|
I've only set up python2 for now. @karmel is currently reviewing python3 and I should hopefully have that up and running later today. |
|
So unfortunately I cannot invoke a separate script (internal infrastructure reasons). I can only invoke bazel targets. I've mirrored your script for now and invoke the bazel targets after running configure. @karmel @seanpmorgan can you confirm you can see the latest logs for both python2/3? |
|
Can confirm py2 and py3 has publicly view-able results. So that I understand the process going forward, you'll need to mirror our CI script anytime its been updated... is that correct? |
|
So here is what the internal script essentially does: So we will try and get to a point where we can just run a script, but like you said until then we may need to coordinate any large differences in your CI script to be mirrored. |
|
Hi, Amit. How can we trigger CI for contributor's PR? I try to apply kokoro:force-run label to #53, it fails unfortunately. Did I do something wrong? |
|
I'm not sure. I'll need to debug why that is happening. Is there any way I can be temporarily given permissions to apply this label? Thanks for your patience as I set this up. |
|
Ah, sorry, I responded in the offending issue-- there was a merge conflict, which was blocking tests. |
|
Could you check #53 ? I take a try again, and it still fails. It seems related with #70, we changed the location of the script. logs:
|
|
I was a little wondering if we could use |
|
Did we merge the move of the testing script? It looks like the attempt to call it in #53 is not finding the script-- |
|
Thanks for the follow-up, yes the script has been moved. This can wait until time allows because we've cut a release branch already for 0.1 and local tests are passing. |
|
I've submitted a change internally to fix this. I've also changed the internal script to just invoke the addons_cpu.sh script. |
No description provided.