Skip to content

Conversation

@av8ramit
Copy link
Contributor

No description provided.

@seanpmorgan
Copy link
Member

seanpmorgan commented Feb 27, 2019

@av8ramit @karmel I was wondering if we could get an update on the CI testing? Does it seem like there's a long-term issue or will it be resolved somewhat soon?

If it is long term then maybe we consider removing the git hook? It's tough to manage PRs with failing build markers throughout the repo

@av8ramit
Copy link
Contributor Author

@seanpmorgan Trying to get this resolved as fast as possible.

@karmel
Copy link
Contributor

karmel commented Feb 28, 2019

@av8ramit Should @seanpmorgan be able to click through to see Py2 results now? @seanpmorgan , can you see them?

@seanpmorgan
Copy link
Member

Py2 yes, Py3 no. Seems like its close 😄

@av8ramit
Copy link
Contributor Author

I've only set up python2 for now. @karmel is currently reviewing python3 and I should hopefully have that up and running later today.

@av8ramit
Copy link
Contributor Author

So unfortunately I cannot invoke a separate script (internal infrastructure reasons). I can only invoke bazel targets. I've mirrored your script for now and invoke the bazel targets after running configure.

@karmel @seanpmorgan can you confirm you can see the latest logs for both python2/3?

@seanpmorgan
Copy link
Member

Can confirm py2 and py3 has publicly view-able results. So that I understand the process going forward, you'll need to mirror our CI script anytime its been updated... is that correct?

@av8ramit
Copy link
Contributor Author

So here is what the internal script essentially does:

virtualenv -p python tf
source tf/bin/activate

pip install --upgrade pip

export CC_OPT_FLAGS='-mavx'
export TF_NEED_CUDA=0 # TODO: Verify this is used in GPU custom-op

export PYTHON_BIN_PATH=$(which python)

N_JOBS=$(grep -c ^processor /proc/cpuinfo)

./configure.sh

INTERNAL_BAZEL_COMMAND \
  test \
  -c opt -k \
  --jobs=${N_JOBS} --test_timeout 300,450,1200,3600 \
  --test_output=errors --local_test_jobs=8 \
  -- \
  //tensorflow_addons/...


So we will try and get to a point where we can just run a script, but like you said until then we may need to coordinate any large differences in your CI script to be mirrored.

@facaiy
Copy link
Member

facaiy commented Mar 4, 2019

Hi, Amit. How can we trigger CI for contributor's PR? I try to apply kokoro:force-run label to #53, it fails unfortunately. Did I do something wrong?

@av8ramit
Copy link
Contributor Author

av8ramit commented Mar 4, 2019

I'm not sure. I'll need to debug why that is happening. Is there any way I can be temporarily given permissions to apply this label? Thanks for your patience as I set this up.

@karmel
Copy link
Contributor

karmel commented Mar 4, 2019

Ah, sorry, I responded in the offending issue-- there was a merge conflict, which was blocking tests.

@facaiy
Copy link
Member

facaiy commented Mar 5, 2019

Could you check #53 ? I take a try again, and it still fails. It seems related with #70, we changed the location of the script.

logs:

Requirement already up-to-date: pip in ./tf/lib/python3.4/site-packages (19.0.3)

  • /bin/bash ci_testing/addons_cpu.sh
    /bin/bash: ci_testing/addons_cpu.sh: No such file or directory

@facaiy
Copy link
Member

facaiy commented Mar 5, 2019

I was a little wondering if we could use make unit-test (or bazel target?). If that, google might not need to care about the location of script any more?

@karmel
Copy link
Contributor

karmel commented Mar 5, 2019

Did we merge the move of the testing script? It looks like the attempt to call it in #53 is not finding the script-- /bin/bash: ci_testing/addons_cpu.sh: No such file or directory CC @av8ramit . We are all in a time crunch today, so if we don't get a chance to fix, you can trust the local runs for now.

@seanpmorgan
Copy link
Member

Thanks for the follow-up, yes the script has been moved. This can wait until time allows because we've cut a release branch already for 0.1 and local tests are passing.

@av8ramit
Copy link
Contributor Author

av8ramit commented Mar 5, 2019

I've submitted a change internally to fix this. I've also changed the internal script to just invoke the addons_cpu.sh script.

@av8ramit av8ramit closed this Mar 5, 2019
@av8ramit av8ramit deleted the test_prs2 branch March 5, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants